Closed
Conversation
Collaborator
Author
|
Closing in favor of #11816 which is on top of this and actually using it for simple migration! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Blocked by: internetarchive/infogami#273
Before this PR, if you called
get_current_userfrom fastapi it would return None because it didn't have the cookie set when site was created. Now, when we create site the cookie is set correctly and we updatedget_current_userto use the context variable instead of web.py context.This is a necessary refactor before we start using endpoints that expect to interact with the
Usermodel.Note: when we start using this in fastapi land we will have to rework how the auth dependencies are setup to work with this.
Technical
Testing
Screenshot
Stakeholders